Fix & document inference/training step

m2lines / gz21_ocean_momentum

Stochastic-Deep Learning Parameterization of Ocean Momentum Forcing

MIT License

5 stars 1 forks source link

Fix & document inference/training step #92

Closed arthurBarthe closed 11 months ago

arthurBarthe commented 1 year ago

The goal of this PR is to fix/clean up the inference code (the testing step), and add documentation regarding its use.

[x] fix potential bugs, due to API changes for instance
[x] describe how to run this step in the documentation ~- [ ] describe how to load the inference output data from the notebook test_global_control~ -> This will be done in #82

review-notebook-app[bot] commented 1 year ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

MarionBWeinzierl commented 11 months ago

It would make sense to maybe rename the "testing" directory into "inference", as otherwise people might expect to find software tests in there.

MarionBWeinzierl commented 11 months ago

@arthurBarthe , in the Jupyter Notebook there are a lot of sections now labelled "IGNORE THIS". Can we delete these, or what are they used for and why should they be ignored?

MarionBWeinzierl commented 11 months ago

It would make sense to maybe rename the "testing" directory into "inference", as otherwise people might expect to find software tests in there.

I am doing this renaming