m2lines / gz21_ocean_momentum

Stochastic-Deep Learning Parameterization of Ocean Momentum Forcing
MIT License
5 stars 1 forks source link

Refactor data step, inference step, Jupyter notebooks #97

Closed raehik closed 9 months ago

raehik commented 10 months ago

This PR covers multiple "feature" changes.

Extra:

Important to-dos:

Closes #87 , #90 , #98 , #4 .

Known bugs:

review-notebook-app[bot] commented 10 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

dorchard commented 9 months ago

Can I request that the module in the cli directory have their _cli_desc put as the first definition after imports with a comment that says # Description of this module or something as they provide a good explanation of what the file is about.

dorchard commented 9 months ago

The section marked ## Data on HuggingFace probably needs to say something about what kind of data and trained model (i.e., that the moment it is low res) and we can update this later if we can get the high-res.