Closed raehik closed 9 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Can I request that the module in the cli
directory have their _cli_desc
put as the first definition after imports with a comment that says # Description of this module
or something as they provide a good explanation of what the file is about.
The section marked ## Data on HuggingFace
probably needs to say something about what kind of data and trained model (i.e., that the moment it is low res) and we can update this later if we can get the high-res.
This PR covers multiple "feature" changes.
Extra:
Important to-dos:
cli/testing.py
(needs better name! check?)cli/infer.py
, but you would have to split the data again yourself for the same behaviour. we could rewrite the dataset splitting used incli/train.py
in some way that it is easy to obtain the correct data to use incli/infer.py
.cli/infer.py
too, we could removecli/testing.py
test_global_control
)xarray.open_zarr
on the forcings and output of inference step).~Closes #87 , #90 , #98 , #4 .
Known bugs:
104
when training,
IndexError: index x is out of bounds for axis 0 with size y
wherex > y
107