search

m2ms / fragalysis-frontend

The React, Redux frontend built by webpack
Other
1 stars 2 forks source link

Target loader tag details #1183

Open tdudgeon opened 1 year ago

tdudgeon commented 1 year ago

We need to decide on what tags the target loader is supposed to create. Currently there are 4 categories of tags (Sites, Series, Forum and Other) and the target loader is assigning a single tag of type Site to a site_observation that looks like this: A/144,A/45,B/191. This correspond to the first 3 residues in the site.

We need to decide on a more complete handling of tags.

  1. do we need tags for canonical site and conformer site (currently I think it's just conformer site that is used).
  2. do we want tags for crystal form (and a new tag category).
  3. do we want tags for macromolecular assembly (and a new tag category).
  4. How do we visually distinguish these different tags. Should the type be used as a prefix e.g. conf_site:A/144,A/45,B/191.
  5. Is the user able for rename a site e.g. change it to active site. Probably out of scope for this discussion, as it involves front end work and policy for who can do this.
phraenquex commented 1 year ago
  1. Yes.
  2. Yes & yes - xtalform: (whatever is in the assemblies.yaml)
  3. Yes & yes - assmb: (whatever is in the assembly.yaml)
  4. Yes. (auto-assign a bright colour to each tag category - feel free to choose
  5. Yes. So don't think too hard about it.
boriskovar-m2ms commented 1 year ago

Frontend needs to be changed to handle tag categories dynamically (it was decided waaay back that tag categories are going to be hardcoded in the backend and frontend)