RHS CSets incorrectly persist when switching targets

[mwinokan]

After changing targets, the compound sets listed in the RHS will show those from the previous target. See images below.

[mwinokan]

RHS for D68EV3C:

RHS after switching to A71EV2A:

A71EV2A has had no RHS uploads so it should look like this:

[boriskovar-m2ms]

What are the steps to reproduce? For me it works A71EV2A has three computed sets from Matteo now though. I go back to landing page and pick another target and it works. This is one of the many reasons why there is that reload when you get back to landing page because there was many garbage not reset in the redux store so it became unmaintainable because the sheer amount of data/state stored in the store caused every now and then something to slip through the cracks so that's why it now "hard resets" when you navigate back to the landing page so in theory this should not be possible but it clearly is.

[mwinokan]

I didn't do anything special. I was just able to reproduce the error by:

• navigating to fragalysis.diamond.ac.uk
• Not logging in
• Clicking the D68 target
• Opening the RHS
• Seeing many different compound sets in the dropdown
• Using the menu to go to "Home"
• Clicking the A71 target
• Opening the RHS and seeing the same compound sets as from D68
• I don't notice a refresh being forced, the home page / target list loads instantly (as if cached)

[boriskovar-m2ms]

Oh I see. "Home" button doesn't trigger this hard reset of the state (basically reloading the page). Forgot that this button even exists... or the whole hamburger menu. Will be easy to bring it in line with behavior when you click on the target in the header