m2ms / fragalysis-frontend

The React, Redux frontend built by webpack
Other
1 stars 1 forks source link

incorrect rendering of snapshot (orientation, contours wrong) #1303

Open phraenquex opened 6 months ago

phraenquex commented 6 months ago

This snapshot should look like this

but renders like this

Definitely orientation and map contour are wrong. Maybe other things too.

boriskovar-m2ms commented 5 months ago

@phraenquex please try now here https://fragalysis-tibor-default.xchem-dev.diamond.ac.uk/ and let me know if it's better

phraenquex commented 5 months ago

@boriskovar-m2ms thanks.

Yes it's better, but not yet correct.

This snapshot should look like this:

but looks like this - renders diff map as well, see that green blob.

phraenquex commented 5 months ago

@boriskovar-m2ms has done lots of fixes in #1321. This one goes back to yellow release.

boriskovar-m2ms commented 5 months ago

Last unresolved issue is that if you restore snapshot which should render density map in it's non-wireframe form it also renders the wireframe form over it

image

This is because restoration process is trying to remove wireframe representation but it's not yet present in the stage object because of the asynchronous nature of density maps loading. Putting in delay or naive synchronization doesn't work.

mwinokan commented 2 months ago

@boriskovar-m2ms please investigate if other aspects of the snapshot context are being reconstructed when the links are followed. Suggested things to investigate:

Fragalysis snapshots should reconstruct the exact UI as visible when the snapshot is generated. I.e. the same as a screenshot, but that can then be interacted with

mwinokan commented 1 month ago

@boriskovar-m2ms is working on this and #1419.

Boris says the scrollbar position may be difficult to implement as resolutions change what can be seen at once. The new spec should be, to set the scroll position so that the first compound displayed in the NGL viewer is visible in the hit navigator (and RHS equivalent).

phraenquex commented 2 weeks ago

Duplicates #1419.