RHS up/down bugs

[phraenquex]

@mwinokan please triage as appropriate. I suspect they're all trivial.

1.

RHS compounds with colours shouldn't remain displayed after hitting up/down buttons (they currently do).

2.

You need to be able to select the text of the names of RHS compounds. I'm guessing it's broken because of 3 below.

3.

You shouldn't be able to move the whole box of each RHS compound. (My mouse goes to move-around cursor when it goes over the box.)

4.

Snapshots don't fully restore the RHS. E.g. this snapshot should look like below - but it's opened the selected compounds tab instead:

5.

Slashes in the method column will cause errors on upload e.g. SeeSAR/Manual

6.

Compound set deletion occasionally throws up 500 errors (the deletion is still successful)

[boriskovar-m2ms]

Currently working on fixing the RHS in the issue #1348 so I assigned this one to me because I can tackle them together

[mwinokan]

@boriskovar-m2ms will look through these and if they are not easy fixes, promote them to new issues

[boriskovar-m2ms]

@phraenquex RHS compounds with colours shouldn't remain displayed after hitting up/down buttons (they currently do). I'm not sure I understand this one. Currently the rule is that if there is a compound that is visible and not locked and you start using the up/down arrows (global or local) you will be asked if you would like to lock these compounds and if not then these compounds are turned off (all the toggles are turned off - L, P, C and S).

What can be in current setup very misleading is when more than one RHS compound uses same LHS observation then it get messy. The reason is that in this case (RHS compound uses LHS observation for rendering of the P, C and S stuff) it acts as it is the same data (it kind of is) so the P, C and S are synchronized for these RHS and LHS elements which doesn't mesh well with how the up/down navigation on RHS works currently. These bugs should be addressed by implementing/fixing issue #1349 where the solution is to 'decouple' linked RHS and LHS elements (RHS compound referencing LHS observation). Unfortunately there is no quick fix or easy win.

[mwinokan]

Thanks @boriskovar-m2ms. I think it's fine to have the surfaces messing with the arrows for RHS uploads with no custom PDB. Our most common RHS use case will be with custom PDB's (once we support it), so I think it's fine if the arrow navigation and interaction visualisation only works properly there.

[boriskovar-m2ms]

points 5 and 6 seems to be backend related

[mwinokan]

Four more small issues for the shopping list that I spotted while testing #1394 :

7. The test for the new generative RHS compound names should use the case from the DB and not all caps. e.g. V1A should be v1a.
8. Clicking the delete dataset button breaks the RHS UI
9. The RHS should open to the compound sets tab by default
10. Columns that are only relevant to the header molecule should not be selectable in the filter and sort (as they are all None):
    • ref_url
    • submitter_*
    • generation_date
    • method