search

m2ms / fragalysis-frontend

The React, Redux frontend built by webpack
Other
1 stars 1 forks source link

Bigger snapshots do not work. #1440

Open boriskovar-m2ms opened 3 months ago

boriskovar-m2ms commented 3 months ago

If a snapshot contains more actions (around 4 MB worth of actions) then restoring usually fails as they do not work more often then they actually do work.

It seems there is some serious synchronization issue.

mwinokan commented 3 months ago

@boriskovar-m2ms has been investigating performance of snapshots, more investigation needed into synchronisation issues to see the work required to fix. Definitely a priority for green/v2.1

mwinokan commented 3 months ago

@boriskovar-m2ms has improved the reliability of reconstructing snapshots with large numbers of actions, especially with weaker connections / computers

boriskovar-m2ms commented 3 months ago

As mentioned in issue #1373 this snapshot doesn't work.

boriskovar-m2ms commented 3 months ago

Seems like false alarm because the reason is that I can't see given target

mwinokan commented 3 months ago

@boriskovar-m2ms I broke the snapshot by removing the compound set, is it possible for the snapshot to restore everything possible, and then stop at the compound set?

  1. Open target
  2. Reinstate NGL orientation
  3. Reinstate LHS UI state
  4. Open RHS
  5. Open RHS compound sets
  6. STOP HERE (if missing correct compound set)
boriskovar-m2ms commented 3 months ago

Problem is that we are restoring actions exactly in the same order as they are captured. I usually try to just skip actions for stuff that is missing but I guess I need to revisit this because these scenarios are usually not tested because it's usually very hard to do so.

But in this case why the snapshot is not working for me is because I don't have access to that target on staging.

mwinokan commented 3 months ago

Oh yes I see now that it requires authentication (which seems to be down due to the power cut). Is it possible to show a login screen for private targets and then resume snapshot restoration?

boriskovar-m2ms commented 3 months ago

Hmmm I'm not sure because without backend changes FE can't distinguish between private targets and deleted targets (for example after data wipe). I need to also investigate how the login mechanism works because currently when you log in you're redirected back to the landing page. Just checked and FE is not in control where user will be redirected after successful login.