Update funding credits - Githubissues

m2ms / fragalysis-frontend

The React, Redux frontend built by webpack

Other

1 stars 2 forks source link

Update funding credits #1465

Open phraenquex opened 5 months ago

phraenquex commented 5 months ago

We have to reflect ASAP, NIH, ALC, Fragment-Screen, Instruct-ERIC, Horizon 2020. The modal was last updated 2019 or so.

It's a trivial code change, so I suggest adding to green (unless it turns out weirdly difficult.)

matej-vavrek commented 5 months ago

Yes, this should be trivial if you present me what and where to put in the layout. @phraenquex, @mwinokan

phraenquex commented 4 months ago

Hi Matej - I've done it all in this powerpoint file.
Contributors - 2024-06(jun).pptx

One page has the icons for the menu bar, to the left of the "Contributors" thing
Second page has icons for the Contributors modal

matej-vavrek commented 4 months ago

@phraenquex I have updated my stack with new credits. I also did some changes so it will be a lot easier to modify these sections and companies overall (you can even directly edit the "config" of my proposal branch).

phraenquex commented 4 months ago

Looks fantastic!

One thing: Can you stretch each gif so that it maximally fills its cell.

matej-vavrek commented 4 months ago

I would say stretching could deform some logos. It would be probably better to have bigger images so they can scale down. I will look for some.

phraenquex commented 4 months ago

Looks great! @boriskovar-m2ms @matej-vavrek would it be easy to make that modal visible by a Restful URL?

If yes, please do for this ticket, and move it back to "in progress" swimlane) If no, please create a new ticket, and move this one to "approved in staging"

matej-vavrek commented 4 months ago

I have reused existing /funders URL and it points to the landing page with open modal instead of old component as we spoke.

phraenquex commented 4 months ago

Thanks @matej-vavrek looks great.

What's still missing is that clicking on "Contributors" (top-right corner, or hamburger menu) should take one to this URL - currently it's still the open modal (as far as I can tell).

Very impressive that you found URLs for all the images!! Super cool...

matej-vavrek commented 4 months ago

@phraenquex, "Contributors" button redirects to /funders URL now.

phraenquex commented 4 months ago

@matej-vavrek . But when I close the modal, it stays on the /funders url, whereas I'd expect it to revert to the previous URL. But this may be non-trivial feature - because that may require rerendering the page?

So the safest fix is: just add the URL to the modal, so people can copy-paste from there.

Do whichever is easiest.

mwinokan commented 4 months ago

@matej-vavrek says the easiest fix is to include a URL in the modal that can be copied.

mwinokan commented 4 months ago

@matej-vavrek has been unable to update his stack with the latest changes due to networking issues on the dev stacks

phraenquex commented 4 months ago

@matej-vavrek add "Copy URL" beisdes the icon.