RHS (Compound) does not set the ManyToMany project_id reference

m2ms / fragalysis-frontend

The React, Redux frontend built by webpack

Other

1 stars 2 forks source link

RHS (Compound) does not set the ManyToMany project_id reference #1485

Open alanbchristie opened 3 months ago

alanbchristie commented 3 months ago

Testing of the security changes (in #1247) has exposed a problem with the RHS uploads. The Compound does not set any Project reference in its project_id column. Consequently the ISPyB filtering blocks the release of any records as there is not Project to compare.

The problem does not appear in the existing stack (staging) because no filtering is being applied.

alanbchristie commented 3 months ago

To resolve this issue we need to identify the Proposals (Projects) new compounds belong to. It is the lack of proposal that is causing the filtering to fail.

The current API endpoint only requires a Target, which can contain more than one Proposal (Project). I suspect that we might also need to add a Proposal (Project) to the upload - e.g. the user is now required to identify both the Target and a Proposal.

Thoughts?

Waztom commented 3 months ago

@alanbchristie is going to use the unique Target name (already on RHS upload page) and assign to compounds that are created when uploading to RHS. Proposal is linked via Targert name.
@alanbchristie will create ticket re relationship of Targets with multiple proposals in a seperate ticket.

alanbchristie commented 3 months ago

Interestingly, the legacy Production Stack does have 16 Targets with two Project/Proposal references: -

FIH 2
GLUK1 2
NS3HEL 2
PGN_RS02895PGA 2
EBNA_A2 2
ADARB1A 2
Nprot 2
CD73 2
SERC 2
TCRUFPPS 2
UP1 2
GLUA2 2
HPRP 2
OXA10 2
PBP5 2
TIF6 2