search

m2ms / fragalysis-frontend

The React, Redux frontend built by webpack
Other
1 stars 2 forks source link

Fix assigning template for ribbon #1507

Open phraenquex opened 2 months ago

phraenquex commented 2 months ago

The ribbons overview is not being properly rendered, becauise the template_protein field is empty.

@kaliif, it's the loader that needs to populate the field, using this rule: it's the protein of the dataset associated with the first assembly in assemblies.yaml.

(If this doesn't explain anything, let me know. I'll need an example set of yamls to check that I'm right, p;lease send me a path.

kaliif commented 2 months ago

@phraenquex this part is clear, there was an issue about it and it's already implemented. But what I don't know, what the spec doesn't say, is which upload the template file is part of. This is what went wrong here, I was looking in a wrong upload directory.

phraenquex commented 2 months ago

Thanks @matej-vavrek - you should be in the upload_1 directory, correct?

kaliif commented 2 months ago

@phraenquex on this one example I've had, CHIKV, it's in upload_1. Is it always there? Never overridden in subsequent uploads?

phraenquex commented 2 months ago

It should always be upload_1 - so do that for now. Thanks!

(@ConorFWild is the one that can confirm if I'm wrong, but let's worry about that if it a bug ever does show up.)

phraenquex commented 2 months ago

@matej-vavrek please move to "won't fix" swimlane (last one) if there's nothing here to fix.

kaliif commented 2 months ago

Moving tow won't fix, this is how it's working right now.