m2ms / fragalysis-frontend

The React, Redux frontend built by webpack
Other
1 stars 2 forks source link

Properly assign/unassign upload tag(s) on incremental uploads #1517

Open mwinokan opened 1 month ago

mwinokan commented 1 month ago

@kaliif I am not sure what the current implementation of the "New" tag that is added to all LHS observations by default, but it should be the following please:

On every upload, please tag all observations with a tag corresponding to their version i.e. create tags upload_1, upload_2

phraenquex commented 1 month ago

@kaliif also need tags that reflect the date of the upload.

mwinokan commented 1 month ago

@kaliif do you already track which uploads correspond to which datasets in the database?

If so, I think we keep this ticket to just assigning the automatic 'upload_*' tags. Else, I think the loader and schema changes should go into #1542

kaliif commented 1 month ago

@mwinokan yes, datasets are tracked and the backend can tell which upload it came from.

@phraenquex does the tag need to contain the date? How should it be formatted?

phraenquex commented 1 month ago

@mwinokan if it's a quick win to add the date, then I'd say:

upload_* yyyy-mm-dd

Then at least text search should work.

mwinokan commented 1 month ago

@kaliif says it's a quick one-line fix to add the date, @phraenquex asks for this to be implemented before handling a bigger F/E change

mwinokan commented 3 weeks ago

@kaliif has implemented the upload_? spec in staging and it looks ok. Date appending is still pending

phraenquex commented 3 weeks ago

@mwinokan if "date appending" is "still pending", then please move this back to "In progress", and @kaliif can you please do it as first priority - so that it can go into production.

(Unless @mwinokan overrides me and says that the datestamp is not necessary - but I didn't hear anybody object before, and Kalev sayid it's a very easy change, as far as I remember.)

mwinokan commented 3 weeks ago

@kaliif needs to check if this was implemented and then deploy it to staging

mwinokan commented 2 weeks ago

Confirmed implemented in staging