search

m2ms / fragalysis-frontend

The React, Redux frontend built by webpack
Other
1 stars 1 forks source link

Using url user will be able to directly display ligand #431

Open boriskovar-m2ms opened 3 years ago

boriskovar-m2ms commented 3 years ago

Using react-router user shall be able to display single ligand of given target for given site. url shall be /target/target_name/site/ligand1/ligand2/ligand3

Max length of the url is 2048 characters. NGL view shall zoom in on the first ligand in the url

reskyner commented 3 years ago

The most important thing is selecting a single ligand. Maybe we don't need to include the site to start with. @phraenquex can explain further

boriskovar-m2ms commented 3 years ago

It will be also possible to search not only among the selected sites/molecule groups but across also un-selected groups. When there are matches which are not part of selected sites then the sites will be selected (? actually TBD - I need to see if it makes sense).

boriskovar-m2ms commented 3 years ago

Search was moved to the issue #446

boriskovar-m2ms commented 3 years ago

The URL structure was changed to: baseurl/viewer/react/preview/direct/target/name_of_the_target/mols/part_of_the_mol_name1/toggle/toggle/.../part_of_the_mol_name2/toggle/toggle/... In bold are variable parts of the URL. name_of_the_target - is the name of the target part_of_the_mol_name1 - it's a part of the molecule name. This doesn't need to be full name because molecule name often contains characters which forbidden in URL. Currently the first match is taken into the account but it can be changed that toggles will be applied to all matches toggle - toggle which will be turned on for given molecule - accepted values: L, P, C, S, V URL length is limited to 2048 characters. After the result is rendered all subsequent selections and/or de selections are not reflected in the URL (the main reason is the URL limit which can be exceeded quite easily when using mass selection toggles but there are also other technicalities like reloading when rewriting URL in react router etc).

All the sites where the molecules in the URL are present should be turned on.

Example: https://fragalysis-tibor-default.xchem-dev.diamond.ac.uk/viewer/react/preview/direct/target/Mpro/mols/X0426/L/P/S/X2608/L/P

teriraj commented 3 years ago

LHS:

  1. The site stop working:

    • when the search field is used
    • when the filter button is used
    • when it is selected one of the predefined filters from dropdown in Hit navigator.

  2. If I turn on the V toggle button, I still don't see any vectors

  3. Too long response:

    • When user wants to save the snapshot (by save button)
    • When user wants to share link (by share button)
boriskovar-m2ms commented 3 years ago
  1. Should be resolved - hopefully without some other unwanted side-effects
  2. Will be resolved at later time - tracked here: #447
  3. Issue is already tracked here #440