search

m2ms / fragalysis-frontend

The React, Redux frontend built by webpack
Other
1 stars 2 forks source link

Finish perspectives #861

Open boriskovar-m2ms opened 2 years ago

boriskovar-m2ms commented 2 years ago

We need to:

  1. split the project view from ngl view.
  2. fix the size of the ngl view (view thinks it's much wider than it actually is) 3. How we can implement tabs (and potentially split the tabs)
  3. add select to select from predefined perspectives
boriskovar-m2ms commented 2 years ago

Related to #846

boriskovar-m2ms commented 2 years ago

Original work is in the #700-grid-layout branch

phraenquex commented 2 years ago

@boriskovar-m2ms please update label with relevant Epic - I think it's E10, but please confirm

boriskovar-m2ms commented 2 years ago

@phraenquex @rsanchezgarc perspectives are in here https://fragalysis-boris-default.xchem-dev.diamond.ac.uk/viewer/react/landing but I think it would best if @ag-m2ms showed you around a little bit.

phraenquex commented 2 years ago

Copied from Slack:

1. LHS and RHS panels too wide.

2. Can you easily make it possible to resize panel widths? That would be the one change that would really improve quality of usage: ability to make the central window wider, or make the panels wider, according to content.

3. This is presumably not the ticket for fixing font sizes? Please confirm. But if it is: Font size of panel headings and height of title bars are far too big. The green-circled font should be the reference font size and widget height. All other widgets in panel should be no more than 2pt larger, and no more than 4pt higher. image

4. The "Reset layout" button does not do anything. It's maybe redundant too, because "default" in the dropdown does the job too, and it actually works. So feel free to delete the "reset layout" button.

ag-m2ms commented 2 years ago

Adjusted solution is in Branch_MergedPerspectives2. Regarding the points:

  1. Panels are resizable, minimal widths and heights removed.
  2. Was already done.
  3. The design was adjusted.
  4. The button is necessary since you can resize panels and in case you want to revert changes. Picking the same option from the layout switcher won't reset the state.
phraenquex commented 2 years ago

Great! Which test pod is this on now?
Reminder: you must let us know on Slack when you've put stuff up for testing.

phraenquex commented 2 years ago

Feedback: vertical font is lovely (thanks!) Left-right width of panels not yet fixed, too wide on my screen. Happy to provide details.

phraenquex commented 2 years ago
  1. Is a hack possible to simply drag the middle pane?
  2. (repeat of #1)
  3. likely ignore, linked to silly screen resolution limitation of library - revisit later?
  4. igore
phraenquex commented 2 years ago

All tricks suggested by @ag-m2ms are lots of work - should not hold up milestones. Will put into new ticket, for proritisation later.