m2sd / LaraNuxt

Laravel framework with integrated NuxtJs support, preconfigured for eslint, jest and vuetify.
55 stars 16 forks source link

:boom: Laravel 7 #3

Closed GautierDele closed 4 years ago

GautierDele commented 4 years ago

Hello, I thought it would be great upgrading this package to Laravel 7, i updated the more dependencies possible in order to match as much as possible the official laravel package.

Wanted to get your attention on 2 points:

https://github.com/laravel/laravel/blob/master/server.php - I removed the "moved permanently part". Can't find it on the official Laravel package - can you confirm it's not usefull ?

https://github.com/skyrpex/laravel-nuxt/commit/3268e5ca01bcedc0bbf91459ed9c5d04789b0856 - I really like the idea of going by the storage path instead of public, is it possible or do we have to change anything in the nuxt-laravel package ?

Just one more point you could add in the nuxt-laravel roadmap - today we can't use nuxt at the root because of many problems (static files are past at the public file, etc). Can we change the package config to be at root by default and allow changes ? I think it's more common.

Thanks, Gautier

GautierDele commented 4 years ago

@mentAl-maZe just mentionning you because i don't think you get the notifications from pull requests 😉

mentAl-maZe commented 4 years ago

Hey @GautierDele,

Thanks for your support.

The "moved permanently part" was added to handle a root path without trailing slash as nuxt had problems with picking up on it when it was configured to be at the root path. I have to admit that this package hasn't gottn a lot of love from me lately so it is possible this is no longer needed

A storage path is possible with the outputPath configuration option

To your last point: Could you open an issue for that, once i have more time i'll get on that

Best regards Michael