search

m35 / jpsxdec

jPSXdec: cross-platform PlayStation 1 audio and video converter
http://jpsxdec.blogspot.com/
469 stars 24 forks source link

Exception when replacing audio #23

Closed jubei85 closed 4 years ago

jubei85 commented 5 years ago

Environment

jPSXdec version: jpsxdec_v1-00_rev3921 debug10.log

Operating system: Windows 10 pro (x64) Java runtime environment: 1.8.0_231-b11

PlayStation Game (if applicable)

Name: Silent Hill 1 Region code:

Description

Replaced the audio: java -jar jpsxdec.jar -x 1.idx -i 1232 -replacexa "HILL[12].wav" java -jar jpsxdec.jar -x 1.idx -i 1232 -replacexa "HILL[12].au" etc.. Everything works in the old version (jpsxdec_v0-99-7_rev3397)

An error appears in the current version: Using source file D:\PSX\ut\jpsxdec\rom\Silent Hill (v1.1).bin 1988 items loaded. ERROR: java.lang.IllegalStateException (IllegalStateException) D:\PSX\ut\jpsxdec>

m35 commented 5 years ago

Thank you for reporting this. Confirmed it is a bug. It was broken when rearranging the replacing logic in v0.99.8. v0.99.7 works perfectly fine at replacing audio if you want to use it. The audio will be replaced in the same way v0.99.8 would if it didn't have this bug.

jubei85 commented 5 years ago

Thank you! Close issue?

m35 commented 5 years ago

This is a good issue to track the bug. I'll close it when it is fixed, thanks 🙂 👍

m35 commented 4 years ago

Fixed https://github.com/m35/jpsxdec/releases/tag/v1.01