m35 / jpsxdec

jPSXdec: cross-platform PlayStation 1 audio and video converter
http://jpsxdec.blogspot.com/
461 stars 24 forks source link

Some WVE files still not detected if scanned from a .bin image. #25

Closed BloodRaynare closed 4 years ago

BloodRaynare commented 4 years ago

Environment

jPSXdec version: jpsxdec_v1-00_rev3921 Operating system: Windows 8.1 x64 Java runtime environment: build 1.8.0_231-b11

PlayStation Game (if applicable)

Name: NASCAR Rumble Region code (e.g. SLUS-1234): SLUS-01068

Description

What were you doing?: I tried to scan the WVE files inside of the image.

What happened?: While almost of them are detected, there's some of the files that aren't detected. NotDetected However, if I open the WVE directly (By extracting it from the image or mount the bin with virtual drive software), it works though OpenedManually

What was or was not supposed to happen?: All of the WVE files inside of the image should be detected.

And here I provided the debug.log as well if it helps debug00.log

m35 commented 4 years ago

Good catch, thanks for the report. The detection logic has a bug. You found a good workaround to extract the file and then open it with jPSXdec.

BloodRaynare commented 4 years ago

Oh yes, I also want to add something. Archived files (like Madden's FMVIDEO.DAT starting with Madden 99) might have some of the WVE stream undetectable as well even when directly opened.

m35 commented 4 years ago

Can you find a specific example of a video that isn't being detected?

BloodRaynare commented 4 years ago

Do you want me to send a sample file? If that's what you mean.

m35 commented 4 years ago

For example, you mentioned there may be WVE videos in Madden 99 FMVIDEO.DAT that are not detected. Can you identify a video in the game that isn't being found by jPSXdec?

BloodRaynare commented 4 years ago

Okay, hold on. I'll try to split the WVE video inside the FMVIDEO.DAT and see which video that didn't detected by jpsxdec. I'll report back when I find out.

BloodRaynare commented 4 years ago

Okay, here'a a small list I gathered (With their offsets and sizes) from my discovery with Madden 99 and 2000:

notdetectedbyjpsxdec.txt

Both of FMVIDEO.DAT's and extracted WVEs (for comparison) were opened directly with jpsxdec. And it seems it always the last occurence of the files inside of the archive that goes undetected.

m35 commented 4 years ago

Give this a try https://github.com/m35/jpsxdec/releases/tag/v1.02

BloodRaynare commented 4 years ago

Almost there..... All of the WVE videos on NASCAR Rumble & Madden 99 are successfully detected. And I think it also fixed one of the videos on Road Rash Jailbreak that was undetected on current latest release as well. However, Madden 2000 still missing one of the videos though. And that's on the offset 08393800 of FMVIDEO.DAT (jpsxdec only detects 35 of 36 of the video files and that video supposed to be after the number 21).

And, also When I tried to scan the NASCAR Thunder 2002 bin images and it's two next iterations (2003 and 2004), jpsxdec give this output on index.log

jPSXdec: PSX media decoder (non-commercial) v1.02 (beta) Windows 8.1 6.3 Java 1.8.0_231 14 Des 19 11:34:23 [INFO] Indexing Filename:F:\Gaming Stuffs\ISOs\Toshiba HDD Backup\PS1\NASCAR Thunder 2002 (USA)\NASCAR Thunder 2002 (USA).bin|Sector size:2352|Sector count:95473|First sector offset:0 [SEVERE] EA video data corruption [INFO] Time: 4 sec

But when I try to scanned that problematic WVEs directly by extracting the DATA.BIN inside of the image, jpsxdec scanned and detected it just fine, still with the warning though.

jPSXdec: PSX media decoder (non-commercial) v1.02 (beta) Windows 8.1 6.3 Java 1.8.0_231 14 Des 19 11:38:33 [INFO] Indexing Filename:F:\Gaming Stuffs\Data Mining & Mod Stuff\NASCAR2K2PSX\DATA\DATA_014.vlc|Sector size:2048|Sector count:7687|First sector offset:0 [WARNING] File does not have raw sector headers -- audio may not be detected. [INFO] Time: 1,32 sec

BloodRaynare commented 4 years ago

It's all perfect now :) All of the videos in various EA games used this format are detected without a hitch.

m35 commented 4 years ago

I can add all the games you tested to the supported PSXListOFGames.txt if you're willing to share.

BloodRaynare commented 4 years ago

Okay, here's a list of the games I tested with:

*Edit: Forgot to add the Game ID

m35 commented 4 years ago

Awesome! Thanks for the game id :D Here's the official release https://github.com/m35/jpsxdec/releases/tag/v1.03

BloodRaynare commented 4 years ago

Late to reply, but thanks. I think it can be closed now.