This PR incorporates the new test package into our unittests. Usage is via the etcdintegration package, which
makes it transparent to the test code; it simply gets an etcd server started via different means.
One piece of weirdness to call out here: the package currently relies on autosync being disabled on the client side.
This is because the advertise client URL (aka what etcd tells clients to connect to) isn't correct for the open port on the host.
That is we have:
etcd: listen on container port 0.0.0.0:2379, advertise 0.0.0.0:2379
docker: expose etcd port 2379 to 0.0.0.0:0 on host machine (random free port)
client: connect to etcd via host machine.
We could probably make this better.
Stack:
4154
4153
⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.
PR 3 for https://github.com/m3db/m3/issues/4144
High level approach is as described in https://github.com/m3db/m3/issues/4144 .
This PR incorporates the new test package into our unittests. Usage is via the
etcdintegrationpackage, which makes it transparent to the test code; it simply gets an etcd server started via different means.One piece of weirdness to call out here: the package currently relies on autosync being disabled on the client side. This is because the advertise client URL (aka what etcd tells clients to connect to) isn't correct for the open port on the host.
That is we have:
We could probably make this better.
Stack:
4154
4153
⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.