m3db / m3

M3 monorepo - Distributed TSDB, Aggregator and Query Engine, Prometheus Sidecar, Graphite Compatible, Metrics Platform
https://m3db.io/
Apache License 2.0
4.74k stars 452 forks source link

etcd_docker 6: Remove etcd embed from M3DB node (#4150) #4204

Closed andrewmains12 closed 1 year ago

andrewmains12 commented 1 year ago

PR 5 for https://github.com/m3db/m3/issues/4144

This PR makes the docker integration tests use containerized etcd. Previously, these relied on M3DB running an embbeded etcd server.

There's no inherent need for this, and it opens us up to dependency issues as described in the linked github issue.

Note: there are a handful that require multiple servers; these are currently "skipped" (commented). I intend to bring those back at a later date..


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.