m3db / m3

M3 monorepo - Distributed TSDB, Aggregator and Query Engine, Prometheus Sidecar, Graphite Compatible, Metrics Platform
https://m3db.io/
Apache License 2.0
4.77k stars 453 forks source link

[m3aggregator] Enable m3agg consumer writers to be able to use multiple filters #4223

Closed saad-zaman closed 1 year ago

saad-zaman commented 1 year ago

What this PR does / why we need it: This PR is needed because we currently cannot use both a storage policy filter and consumer service filter inside m3aggregator for a single consumer, we can only use one filter. This limits us from being able to filter on shardSet and storage policy which may be required. Here we currently register filters in a map keyed by serviceID, so if a service has more than one filter it gets overwritten.

Special notes for your reviewer: N/A

Does this PR introduce a user-facing and/or backwards incompatible change?: No Does this PR require updating code package or user-facing documentation?: No