search

m3db / m3em

A cluster environment manager
Apache License 2.0
1 stars 0 forks source link

[gometalinter] Add gometalinter and address any issues it raises #12

Closed jeromefroe closed 6 years ago

jeromefroe commented 7 years ago

Added gometalinter to m3em so I could start to familiarize myself with the code a little more.

@prateek @xichen2020

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 69.958% when pulling 9f7d7702b0fea94a9a6784bdef9a2ae766c6cd83 on jeromefroe/add-gometalinter into f89beabde940cd31ca77c700a8ecc3fee8e2d3a9 on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 69.958% when pulling 4e7dc5833a31627da72b2c88d85f634064d3fdb5 on jeromefroe/add-gometalinter into f89beabde940cd31ca77c700a8ecc3fee8e2d3a9 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.05%) to 69.907% when pulling 8d4034973f1fc29b4d994f39d74f6282cd78688f on jeromefroe/add-gometalinter into f89beabde940cd31ca77c700a8ecc3fee8e2d3a9 on master.

prateek commented 7 years ago

@jeromefroe looks like there's a merge conflict with Chao's latest change.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 69.907% when pulling e112943b169fbec69e3badb60ddd461e8bd82a1d on jeromefroe/add-gometalinter into f011c9da127dc8f7dd132c3d8c59814e96e6971f on master.

jeromefroe commented 7 years ago

@prateek yep, just updated if you wouldn't mind taking another look whenever you get a chance.