search

m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.
https://gokart.readthedocs.io/en/latest/
MIT License
305 stars 57 forks source link

Improve Slack error handling #153

Closed hirosassa closed 3 years ago

hirosassa commented 3 years ago

What is this PR?

Related to https://github.com/m3dev/gokart/pull/141

Since current implementation cares Slack service related failures only, the task will be fail when network related issue occurs.

I implemented codes which catches all the exceptions.

hirosassa commented 3 years ago

@Hi-king @vaaaaanquish @mski-iksm @e-mon Bit change. Plz review!

mski-iksm commented 3 years ago

LGTM!