m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.
https://gokart.readthedocs.io/en/latest/
MIT License
318 stars 57 forks source link

Migrate to GitHub Actions #161

Closed hirosassa closed 3 years ago

hirosassa commented 3 years ago

What is this PR?

TSIA

I added following workflow on GitHub Actions

hirosassa commented 3 years ago

I think diff is broken...

hirosassa commented 3 years ago

Please review following two files only (other differences are not related to this PR, it's broken)

Also, we need to discuss on handling pypi secrets.

vaaaaanquish commented 3 years ago

@hirosassa What do you care about pypi secrets?

No matter whose account secret you use, it cannot be seen by others. Because secret is update only.

sc

OR

We can use oganization secrets:) https://github.blog/changelog/2020-05-14-organization-secrets/

hirosassa commented 3 years ago

@vaaaaanquish Thanks for your comment! I did not know about the spec of github secrets. I'll implement the publish to pypi in this PR.

hirosassa commented 3 years ago

@vaaaaanquish @Hi-king Added publish workflow! Plz review.

vaaaaanquish commented 3 years ago

LGTM