make s3 config singleton

m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.

https://gokart.readthedocs.io/en/latest/

MIT License

305 stars 57 forks source link

Closed mski-iksm closed 3 years ago

mski-iksm commented 3 years ago

[What?] I've made S3Config's S3Client as singleton.

[Why?] The original code makes one S3Client for each loading file, which causes connection error when loading many files from S3.

Please review! @Hi-king @hirosassa @vaaaaanquish

hirosassa commented 3 years ago

Thanks! LGTM!

Hi-king commented 3 years ago

@mski-iksm LGTM!