doesn't working GCSClient>=2.0

m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.

https://gokart.readthedocs.io/en/latest/

MIT License

305 stars 57 forks source link

doesn't working GCSClient>=2.0 #187

Closed vaaaaanquish closed 3 years ago

vaaaaanquish commented 3 years ago

 File "/usr/local/lib/python3.7/site-packages/gokart/gcs_config.py", line 39, in _get_gcs_client
   content = _retrieve_discovery_doc(requested_url, discovery_http, False)
TypeError: _retrieve_discovery_doc() missing 2 required positional arguments: 'serviceName' and 'version'

https://github.com/googleapis/google-api-python-client/commit/32d1c597b364e2641eca33ccf6df802bb218eea1#diff-b039ba2bb64e79cf[…]9be872fd2d46047c05cbb

Hi-king commented 3 years ago

Fixed thx to @hirosassa