Closed hiro-o918 closed 3 years ago
@hiro-o918 Thanks great suggestions. Is it possible to apply a yapf formatter?
LGTM. I'll wait for the @Hi-king review.
@hiro-o918 LGTM! Thank you for your contribution!
Cool solution! For workaround, currently we're using __version=IntParameter(default=2)
for declaring the change of task definition 💦 This way looks more sophisticated to me !
Thank you for your fast your reviews! :rocket:
@hiro-o918 gokart 1.0.1 including your great contribution is released. Thanks again!
What
Add a feature to create a hash of a task. The hash is created by
cloudpickle.dumps
to the class object of a task.Why
Current implementation assumes that an output is determined by input parameters and requirements. But this assumption does not work, when the implementation of a task changes.
As a results, some issues can occur.
.pkl
to rerun tasksmodification_time_check
can resolve this in some aspects (I like this option).pkl
must be removed as well as local development.So, adding task definition to hash resolves these issues and re-reruns tasks safely.
Discussion
cloudpickle