m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.
https://gokart.readthedocs.io/en/latest/
MIT License
305 stars 57 forks source link

added option to cache_unique_id #213

Closed TaylerUva closed 3 years ago

TaylerUva commented 3 years ago

added option to cache_unique_id maintains backwards compatibility fixes #210

vaaaaanquish commented 3 years ago

@TaylerUva Thx. 🆒 Can you write unittest?

hirosassa commented 3 years ago

Thanks for your contribution! Your change looks good. Please fix formatting, and add UT for this change.

hirosassa commented 3 years ago

Looks great! Thank you @TaylerUva !

vaaaaanquish commented 3 years ago

Thanks. 🆒

Hi-king commented 3 years ago

Merged! Thx for your great contribution @TaylerUva

And for reviews @vaaaaanquish @hirosassa