Change unique_id when code contents are changed

m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.

https://gokart.readthedocs.io/en/latest/

MIT License

318 stars 57 forks source link

Change unique_id when code contents are changed #227

Closed mski-iksm closed 3 years ago

mski-iksm commented 3 years ago

Currently, when dependent tasks (tasks defined in requires()) and parameters are unchanged, unique_id of task output will be same. This is confusing since the task will not re-run when only implementation of run() is changed.

https://github.com/m3dev/gokart/pull/205 tried to solve this problem, however there was a problem and therefore reverted. https://github.com/m3dev/gokart/issues/207

mski-iksm commented 3 years ago

Using inspect.getsource maybe an idea, however it may not work when task class is defined in jupyter notebook. https://github.com/ipython/ipython/issues/11249

mski-iksm commented 3 years ago

This issue has been resolved at https://github.com/m3dev/gokart/pull/252 . Thank you @ujiuji1259 !