m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.
https://gokart.readthedocs.io/en/latest/
MIT License
318 stars 57 forks source link

fix LoggerConfig inconsistency bug #233

Closed mski-iksm closed 3 years ago

mski-iksm commented 3 years ago

gokart.build() has a feature to disable low important logs. However, the implementation has inconsistency,

This is because logging.Logger.setLevel and logging.disable has the following difference.

setLevel: Logging messages which are less severe than level will be ignored logging.disable: disable all logging calls of severity level and below

This PR fix the inconsistency by disabling any logs with level below the self.level

hirosassa commented 3 years ago

Thanks! LGTM