m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.
https://gokart.readthedocs.io/en/latest/
MIT License
305 stars 57 forks source link

Refactored make_tree_info #234

Closed mski-iksm closed 3 years ago

mski-iksm commented 3 years ago

As discussed in https://github.com/m3dev/gokart/pull/232#issuecomment-897282110, I've refactored back end script of make_tree_info and moved them to gokart.tree.task_info.

mski-iksm commented 3 years ago

Please review! @vaaaaanquish @Hi-king @hirosassa

vaaaaanquish commented 3 years ago

Very good PR. LGTM.

mski-iksm commented 3 years ago

Thank you for the comments. I'll merge this PR.

Hi-king commented 3 years ago

cool refactoring 😸