search

m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.
https://gokart.readthedocs.io/en/latest/
MIT License
318 stars 57 forks source link

[Bug] NameError is raised when execute gokart.run() with _try_tree_info() in IPython #247

Closed yuta100101 closed 3 years ago

yuta100101 commented 3 years ago

Running the following code will raise NameError in IPython.

import gokart

class Task(gokart.TaskOnKart):
    pass

gokart.run(["Task", "--tree-info-mode=simple"])
NameError: name 'exit' is not defined

And the same is true when execute gokart.run(["Task", "--delete-unnecessary-output-files"]).

This might be resolved by replacing exit() with sys.exit() in _try_tree_info() and _try_to_delete_unnecessary_output_file().

Hi-king commented 3 years ago

@yuta100101

We believe #248 have fixed this :)

And we've released hotfix version 1.0.4 of gokart.

Really thx for your contribution!