search

m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.
https://gokart.readthedocs.io/en/latest/
MIT License
305 stars 57 forks source link

add gokart.testing.assert_frame_equal #256

Closed mski-iksm closed 2 years ago

mski-iksm commented 2 years ago

I've added a new feature gokart.testing.assert_frame_equal() for comparing pd.DataFrame.

As mentioned in the issue, this is useful when index/columns orders are different.

Related issue: https://github.com/m3dev/gokart/issues/243 raised by @vaaaaanquish

Please review!

Hi-king commented 2 years ago

@mski-iksm thx I've understand functionalities!

IMO, how about more descriptive name indicating difference (e.g. assert_frame_contents_equal, assert_frame_equal_ignoring_index)

mski-iksm commented 2 years ago

@Hi-king

IMO, how about more descriptive name indicating difference (e.g. assert_frame_contents_equal, assert_frame_equal_ignoring_index)

I agree with your idea. I've changed the method name assert_frame_equal -> assert_frame_contents_equal .

Please review.

Hi-king commented 2 years ago

@mski-iksm 🆒 LGTM!

Hi-king commented 2 years ago

@mski-iksm Thx for cool function :) Merged!