m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.
https://gokart.readthedocs.io/en/latest/
MIT License
305 stars 57 forks source link

Add exist check before removing file #270

Closed mski-iksm closed 2 years ago

mski-iksm commented 2 years ago

I've added existence check to ModelTarget._remove() as like in SingleFileTarget._remove().

Also, I've changed existence check of SingleFileTarget._remove() to use self._exists().

Please review!

hirosassa commented 2 years ago

LGTM!