Bugfix: assert when redis_timeout is too short

m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.

https://gokart.readthedocs.io/en/latest/

MIT License

305 stars 57 forks source link

Closed mski-iksm closed 2 years ago

mski-iksm commented 2 years ago

redis_timeout which defines the time before redis lock evaporates, cannot be shorter than 10 seconds, because redis lock is extended every 10 seconds. https://github.com/m3dev/gokart/blob/master/gokart/redis_lock.py#L58

This PR adds an assert to check that the timeout is not too short.

Please review!

Hi-king commented 2 years ago

@mski-iksm cool! thx

@hirosassa thx for reviews