m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.
https://gokart.readthedocs.io/en/latest/
MIT License
305 stars 57 forks source link

Update documentation for fail_on_empty_dump #282

Closed yamasakih closed 2 years ago

yamasakih commented 2 years ago

What I did

Hi-king commented 2 years ago

@yamasakih Really thanks for fixing the wrong documentation!

LGTM

Anyway, another example to use fail_on_empty_dump in notebook is as follows.

class EmptyTask(gokart.TaskOnKart):
    fail_on_empty_dump: bool = ExplicitBoolParameter(default=True, significant=False) #override TaskOnKart.fail_on_empty_dump
    def run(self):
        df = pd.DataFrame()
        self.dump(df)

gokart.build(EmptyTask())

We can override fail_on_empty_dump on any tasks instead of injecting it from conf

mski-iksm commented 2 years ago

@yamasakih Thank you for fixing the document! LGTM!

Hi-king commented 2 years ago

@yamasakih Thx for your contribution!

yamasakih commented 2 years ago

@Hi-king

Thank you for introducing another way. I thought it was very nice because I thought it was one way to override as you said.

@mski-iksm Thank you for your suggestion!