m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.

https://gokart.readthedocs.io/en/latest/

MIT License

318 stars 57 forks source link

Suppress heavy logs on test (fix #284) #285

Closed Hi-king closed 2 years ago

Hi-king commented 2 years ago

Fixes #284

FIXES

1. reconfigure luigi.setup_logging configs on each setUp and tearDown
1. gokart.build() propagate log_level also to luigi namespace

PROBLEMS: heavy logs

https://github.com/m3dev/gokart/runs/6319432334?check_suite_focus=true

Reason1: cache of logging cofiguration

luigi.BaseLogging has cache for disabling re-configuration
- https://github.com/spotify/luigi/blob/4d0576c7c265afcb228097af79f316ba0de0242c/luigi/setup_logging.py#L57
So, '--log-level=CRITICAL' of each test does noting
- https://github.com/m3dev/gokart/blob/210e282303b4ca3013bd0acd781f6030547a773a/test/test_pandas_type_check_framework.py#L64

Reason2: gokart.build(log_level=...) only set log_level of `gokart` namespace

Info level logs from luigi namespace had been shown.