search

m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.
https://gokart.readthedocs.io/en/latest/
MIT License
318 stars 57 forks source link

fix: annotation of inherits_config_params #289

Closed yuta100101 closed 2 years ago

yuta100101 commented 2 years ago

inherits_config_params is not called with TaskOnKart instance but TaskOnKart class itself or its subclass. This suppresses mypy error. And task_class is better for the parameter name than task. I think this change does not have a significant impact on usage because inherits_config_params is used as decorator.