search

m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.
https://gokart.readthedocs.io/en/latest/
MIT License
318 stars 57 forks source link

set columns with list #299

Closed mski-iksm closed 2 years ago

mski-iksm commented 2 years ago

Problem: gokart could not use pandas>=1.5.0

In pandas>=1.5.0, columns cannot be declared with set(). https://pandas.pydata.org/docs/whatsnew/v1.5.0.html#other-api-changes

However, gokart.TaskOnKart.required_columns will use set() to build pd.DataFrame when required_column is set with set() and pd.DataFrame is empty.

I changed the code to convert set to list and then build pd.DataFrame.

hirosassa commented 2 years ago

Your changes looks good 👍 Please check the CI running on Python 3.10.