Set encoding when saving csv

m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.

https://gokart.readthedocs.io/en/latest/

MIT License

318 stars 57 forks source link

Closed mski-iksm closed 1 year ago

mski-iksm commented 1 year ago

I've added CsvFileProcessor._encoding to allow specifying encodings when dumping in csv.

Hi-king commented 1 year ago

@mski-iksm Could you consider adding some light load/save test cases?

ukky17 commented 1 year ago

LGTM

hirosassa commented 1 year ago

@mski-iksm just a friendly reminder. What's this PR status?

mski-iksm commented 1 year ago

@mski-iksm just a friendly reminder. What's this PR status?

@hirosassa I'm still working on adding tests. Please wait for few more days.

mski-iksm commented 1 year ago

@Hi-king I've added small tests. Please re-review. Thank you.

Hi-king commented 1 year ago

@mski-iksm THX!LGTM!