Closed kitagry closed 8 months ago
I think we need to re-lock to update numpy to 1.26. https://github.com/m3dev/gokart/blob/master/poetry.lock#L1224
ref: https://numpy.org/news/#numpy-1260-released
P.S. From the numpy document displayed above, we need to deprecate Python 3.8.
Hmm. numpy 1.25 drop Python 3.8 support. https://github.com/numpy/numpy/releases/tag/v1.25.1
So, in order to we support numpy 1.26 we should drop Python 3.8.
Do you think about this? @hirosassa @Hi-king @mski-iksm @ujiuji1259
I agree with dropping Python38 coz they ended active support on May 2021.
Hmm, pyarrow doesn't support python3.12 yet. https://github.com/apache/arrow/issues/37880
@kitagry hooray!! 🎉 it will be published in around 2w https://github.com/apache/arrow/issues/37880
@Hi-king @mski-iksm @ujiuji1259 @hirosassa Please review!
And, is it ok to remove python 3.8 test CI from required and add python 3.12 test CI to required?
@kitagry THX!
I've changed required actions :)
and some changes.
is
/is not
, for instance checks useisinstance()
type(hoge) == fuga
toisinstance(hoge, fuga)