m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.
https://gokart.readthedocs.io/en/latest/
MIT License
305 stars 57 forks source link

support Python 3.12 #325

Closed kitagry closed 8 months ago

kitagry commented 11 months ago

and some changes.

hirosassa commented 11 months ago

I think we need to re-lock to update numpy to 1.26. https://github.com/m3dev/gokart/blob/master/poetry.lock#L1224

ref: https://numpy.org/news/#numpy-1260-released

P.S. From the numpy document displayed above, we need to deprecate Python 3.8.

kitagry commented 11 months ago

Hmm. numpy 1.25 drop Python 3.8 support. https://github.com/numpy/numpy/releases/tag/v1.25.1

So, in order to we support numpy 1.26 we should drop Python 3.8.

Do you think about this? @hirosassa @Hi-king @mski-iksm @ujiuji1259

hirosassa commented 11 months ago

I agree with dropping Python38 coz they ended active support on May 2021.

https://endoflife.date/python

kitagry commented 11 months ago

Hmm, pyarrow doesn't support python3.12 yet. https://github.com/apache/arrow/issues/37880

hirosassa commented 11 months ago

@kitagry hooray!! 🎉 it will be published in around 2w https://github.com/apache/arrow/issues/37880

kitagry commented 8 months ago

@Hi-king @mski-iksm @ujiuji1259 @hirosassa Please review!

And, is it ok to remove python 3.8 test CI from required and add python 3.12 test CI to required?

Hi-king commented 8 months ago

@kitagry THX!

Hi-king commented 8 months ago

I've changed required actions :)

image