search

m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.
https://gokart.readthedocs.io/en/latest/
MIT License
305 stars 57 forks source link

[docs] fix csv encoding option #327

Closed ujiuji1259 closed 11 months ago

ujiuji1259 commented 11 months ago

https://github.com/m3dev/gokart/pull/317 added the encoding option into CsvFileProcessor, but the following code in the docs doesn't work.

def output(self):
    return self.make_target('file_name.csv', encoding='cp932')

In fact, we have to directly pass CsvFileProcessor with encoding='cp932' to TaskOnKart.make_target.

Hi-king commented 11 months ago

@ujiuji1259 THX!