added @functools.wraps(run_func) to task_complete_check_wrapper

m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.

https://gokart.readthedocs.io/en/latest/

MIT License

305 stars 57 forks source link

Closed mski-iksm closed 8 months ago

mski-iksm commented 10 months ago

I've added @functools.wraps not to change wrapped function's name.

Hi-king commented 8 months ago

LGTM!

yokomotod commented 8 months ago

@mski-iksm Can we have any kind of unit test ?

I'm not sure what problem happen if decorate function name changed. (but yes, sounds problem 😅

I's great if we have concrete problem case and confirm it is prevented

mski-iksm commented 8 months ago

@yokomotod This PR is not to fix any bug, instead it is for readability.

So there is no concrete problem case, and therefore I think no test is required.

yokomotod commented 8 months ago

I see, then I agree to not have unit test for @functools.wraps functionality itself !

and +1 for using @functools.wraps habit