search

m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.
https://gokart.readthedocs.io/en/latest/
MIT License
305 stars 57 forks source link

set TaskOnKart.raise_task_lock_exception_on_collision as false #342

Closed mski-iksm closed 8 months ago

mski-iksm commented 8 months ago

RedisParams.raise_task_lock_exception_on_collision is a option whether to fail when TaskLockException is raised (when True), or just wait until the lock is released (when False).

Originally, this setting was passed from TaskOnKart.raise_task_lock_exception_on_collision. However, this option is not needed since task collision lock of TaskOnKart.dump() don't want to fail even when TaskLockException is raised. Rather, we want to wait until the lock is released.

In this PR, I've changed the raise_task_lock_exception_on_collision as False for task collision lock of TaskOnKart.dump().