search

m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.
https://gokart.readthedocs.io/en/latest/
MIT License
305 stars 57 forks source link

bugfix: FeatherFileProcessor set wrong index #359

Closed kitagry closed 6 months ago

kitagry commented 6 months ago

When original DataFrame doesn't set index name, FeatherFileProcessor set index_name as 'None'.

Why we don't fix dump not to dump index None?

It is important for the compatibility, the already dumped feather file has the name __feather_gokart_index__None. And I think no one doesn't set "None" name index. :wink:

mski-iksm commented 6 months ago

LGTM! Thank you for bugfix!