m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.
https://gokart.readthedocs.io/en/latest/
MIT License
305 stars 57 forks source link

add type aware flatten method instead of `luigi.task.flatten` #362

Closed kitagry closed 5 months ago

kitagry commented 5 months ago

Currently, we use luigi.task.flatten, but this method is not type aware (it return type is always Unknown. Because of this, we wrote missed type here ( it should be List[str], but List[TaskOnKart] ).

So, I introduce type aware flatten method instead of luigi.task.flatten

kitagry commented 5 months ago

TypeAlias is not support in Python3.9 😮‍💨

Hi-king commented 5 months ago

LGTM