search

m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.
https://gokart.readthedocs.io/en/latest/
MIT License
305 stars 57 forks source link

bugfix: output_paths type is wrong #366

Closed kitagry closed 5 months ago

kitagry commented 5 months ago

In the following code, output_path is converted from TargetOnKart.path() which returns str. I'll trying to avoid this error with strict type in https://github.com/m3dev/gokart/pull/362, but this is a bit difficult for Python 3.9.

https://github.com/m3dev/gokart/blob/master/gokart/tree/task_info_formatter.py?plain=1#L68

tkda-h3 commented 5 months ago

LGTM

Hi-king commented 5 months ago

LGTM!