fix load_dill_with_pandas_backward_compatibility() bug

m3dev / gokart

Gokart solves reproducibility, task dependencies, constraints of good code, and ease of use for Machine Learning Pipeline.

https://gokart.readthedocs.io/en/latest/

MIT License

318 stars 57 forks source link

Closed mski-iksm closed 3 months ago

mski-iksm commented 4 months ago

When pd.read_pickle(file) failed, load_dill_with_pandas_backward_compatibility() will fall back and use dill.load(file).

But before loading with dill, file cursor must be rewind to the beginning.

Hi-king commented 4 months ago

@mski-iksm Thx for pointing out a critical bug. Could you tell me which commit do you think this bug was introduced in?

Hi-king commented 4 months ago

I hope a fixed test will be added to test/test_file_processor.py 🙏

kitagry commented 4 months ago

LGTM other than comments

mski-iksm commented 4 months ago

@mski-iksm Thx for pointing out a critical bug. Could you tell me which commit do you think this bug was introduced in?

This bug was introduced in the following PR

Hi-king commented 3 months ago

@mski-iksm THX for quick and careful bugfix :)