search

m42e / mayan-automatic-metadata

A (to be) framework for automatic, external processing of mayan documents for assigning tags and metadata
13 stars 4 forks source link

Tweaks for my usage #2

Closed oohlaf closed 4 years ago

oohlaf commented 4 years ago

Hi,

Thanks for creating this. I made some minor changes when using it.

Removed some hardcoded assumptions like not rewriting the mayan connect string for https for usage within docker (and when there is a frontproxy like Traefik). Also a hardcoded document ID.

I changed the language specific parser to accept kwargs so the language can be passed from the plugin.

Not sure if you're open to merging, just wanted to let you know. Hopefully the Mayan 4.0 will get something as flexible for parsing metadata from documents.

Thanks

dontoverthinkit commented 4 years ago

Just a quick note to thank you @oohlaf - I was just getting ready to do the same set of changes (I am running a reverse proxy in front of mayan as well) - I'd find this pull request really helpful as well.

@m42e - thanks heaps for putting this together, really appreciate it!