search

m43nu / angular-auto-height

An AngularJS directive to automatically adjust the height of an element corresponding to the parent and siblings.
MIT License
16 stars 5 forks source link

If attribute value is 'min-height', set that CSS property instead. #2

Open morganiq opened 9 years ago

morganiq commented 9 years ago

To allow vertical expansion of the container below the fold for content tall enough to do so, look for an optional value of min-height and, if present, set that property instead of height. Includes README update.

Note: CoffeeScript edits untested. Manually edited and tested JavaScript source only.

m43nu commented 9 years ago

Thanks for your addition! I checked your CoffeeScript source and it won't work like this, though..

You need to change the code to: property = if $attrs.autoHeight == 'min-height' then 'min-height' else 'height'

If you can make this change by yourself, I will test and merge the PR afterwards.

morganiq commented 9 years ago

Fixed! Sorry, forgot about this PR for a while.

m43nu commented 9 years ago

Thank you for fixing it.

I will check it out later today.

severinraez commented 9 years ago

hi morganiq

i just talked to m43nu about this stalled request - the cause we didn't merge it yet is the remaining merge conflicts. would you mind fixing them? alternatively we'll do - sometime ;)

morganiq commented 9 years ago

Sorry again for the delay; I've merged the changes. Again, I manually edited and tested the JavaScript source only. CoffeeScript changes were eyeballed and are untested.

morganiq commented 8 years ago

Updated with properly re-generated and disted auto-height.js, resolving the merge conflict. Manually tested in browser; should be good to merge now. Sorry for not keeping an eye on this!