search

m4b / goblin

An impish, cross-platform binary parsing crate, written in Rust
MIT License
1.2k stars 160 forks source link

Fixed #267 #268

Closed 2vg closed 3 years ago

2vg commented 3 years ago

related: https://github.com/m4b/goblin/issues/267

The problem here was solved by using parse_with_otps. I had some time, so I debugged and confirmed that the problematic code I presented didn't cause any problems. No tests were added because I didn't have time to write the tests. If you have time, please help me :<

m4b commented 3 years ago

@2vg thank you for the patch! LGTM, looks like rustfmt failed, can you run it on that file? thanks, once CI passes can merge

m4b commented 3 years ago

@2vg thank you for your patience, merged; would you like a new release? I will likely add this to the 0.4 release, which has one (minor) breaking change, but which should not affect your usecase at all (PE, iiuc)

m4b commented 3 years ago

Ok 0.4.0 is out :)