search

m4b / goblin

An impish, cross-platform binary parsing crate, written in Rust
MIT License
1.17k stars 156 forks source link

mach: Implement `LC_BUILD_VERSION` #341

Closed messense closed 1 year ago

messense commented 1 year ago

Closes #255

m4b commented 1 year ago

Just had the one question about method, otherwise lgtm

m4b commented 1 year ago

thanks @messense ! do you need a point release for this soon or it's ok to wait a bit and collect some other PRs?

messense commented 1 year ago

It's ok to wait for a while.

messense commented 1 year ago

Hi @m4b, do you plan to release a new version soon? I'd like to use this for https://github.com/PyO3/maturin/issues/1252, thanks!

m4b commented 1 year ago

@messense sorry for delay life was busy, do you also need https://github.com/m4b/goblin/pull/342 ? I was considering branching and cherry-picking the non-breaking changes and delaying 342 until another breaking change? But if you need it can just release all at once in 0.7

messense commented 1 year ago

I dont need it.

m4b commented 1 year ago

@messense published all non-breaking changes as 0.6.1, and new 0.6.1 branch along with git tag, thanks for your patience!